Re: [PATCH]: rivafb DDC2/I2C

On Tue, 2004-01-13 at 01:38, Kronos wrote:

                        *mode = vesa_modes[i];
-                       return 1;
+                       mode->flag |= MODE_IS_STANDARD;
+                       break;
+               } else {
+                       calc_mode_timings(xres, yres, refresh, mode);
+                       mode->flag = MODE_IS_STANDARD | MODE_IS_CALCULATED;
+                       break;
                }
        }

This won't work. It will exit after the first iteration in any case. You
reintroduced the same bug you spotted some time ago ;)

Thanks :-).  Fixed.

Also, I see that you introduced fb_sqrt, we already have int_sqrt (see
lib/int_sqrt.c). If the only issue was the return value you can change
fb_sqrt to:

static inline u32 fb_sqrt(int x) {
        return (u32)int_sqrt(x);
}

No issue.  Fixed.

quoted

2. modedb.c
- removed __init for fb_find_mode().

You have to change the prototype in fb.h. fb_find_mode was implemented
in a different way if MODULE was defined.

Ok.

And if we are keeping modedb (~2.7KB) after initialization we should
merge it with vesa_modes (we still have MODE_IS_VESA flag) and remove 
duplicates.

Possibly.  Will be on my TODO.

Tony






-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html