Re: Re: FBDEV 2.6.0-test7 updates.
From: Michel Dänzer <hidden>
Date: 2003-10-16 00:25:53
Also in:
lkml
On Thu, 2003-10-16 at 01:20, Andrew Morton wrote:
quoted hunk ↗ jump to hunk
This one comes up again and again. What should we do with it?--- 25/drivers/video/radeonfb.c~radeonfb-line_length-fix 2003-10-05 09:17:58.000000000 -0700 +++ 25-akpm/drivers/video/radeonfb.c 2003-10-05 09:17:58.000000000 -0700@@ -2090,7 +2090,7 @@ static int radeonfb_set_par (struct fb_i } /* Update fix */ - info->fix.line_length = rinfo->pitch*64; + info->fix.line_length = mode->xres_virtual*(mode->bits_per_pixel/8); info->fix.visual = rinfo->depth == 8 ? FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_DIRECTCOLOR; #ifdef CONFIG_BOOTX_TEXT
I'd say drop it, as it's wrong. :) It's like this in Ben's tree:
/* Update fix */
if (accel)
info->fix.line_length = rinfo->pitch*64;
else
info->fix.line_length = mode->xres_virtual * ((mode->bits_per_pixel +
1) / 8);
--
Earthling Michel Dänzer \ Debian (powerpc), XFree86 and DRI developer
Software libre enthusiast \ http://svcs.affero.net/rm.php?r=daenzer
-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php