Re: [PATCH] matroxfb: New framebuffer_alloc API and class_d

On 15 Sep 03 at 22:16, Kronos wrote:

Hi,
this patch converts driver/video/matrox to framebuffer_alloc. Now
fb_info (and minfo) are dynamically allocated. This also voids the need 
of a global matrox_fb_info if CONFIG_FB_MATROX_MULTIHEAD:

                             ^^^ if not defined

Whole point of CONFIG_FB_MATROX_MULTIHEAD is to use static structure
when MULTIHEAD is not set. It generates much faster driver for ia32 due
to smaller register pressure, as driver data can be addressed with fixed
address instructions. So if you are going to always allocate fbcon
dynamically, please also remove CONFIG_FB_MATROX_MULTIHEAD completely,
making it always enabled.

Besides that, what's the point of this change? Making driver slower, 
scattering its data over random memory places (so no cache locality...), 
or is there some benefit it brings in and which I missed?
                                        Thanks,
                                                Petr Vandrovec
                                                



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf