Bug in software cursor flash code, when align!=1?

Hi Again

Being puzzled by the fact that my software cursor did not work when
everything else worked with my accelerated routines I tried to investigate
where the problem was located. This being when scan_align!=1 which
my accel routines need.

I suspected the flash code in the software cursor routines, so I
changed the flash frequence to 1 per second. This showed me that
the first image (== combination of the cursor and the underlying char)
is good enough. After a second the cursor flash code gets called
and I get garbage where the cursor are. When I move the cursor to another
position I once more get one good image and garbage after that.

To rule out that my accell functions caused this I put in a

	for(i=0;i<64;i++)
		info->cursor.image.data[i]=1<<((i>>2) &0x07);

between

	info->cursor.image.data = dst;
        
and
        info->fbops->fb_imageblit(info, &info->cursor.image);

in softcursor.c. This gave me the expected / image all the time.
                                           /

I did not have the time to investigate this very much further, but I
suspect that the problem lies with the xor/copy functions in
softcursor.c not taking alignment into account on subsequent calls.

Just for information. 

Regards Thomas, Denmark


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf