Re: [PATCH] fix controlfb and platinumfb drivers
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2003-05-28 12:23:09
Also in:
lkml
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2003-05-28 12:23:09
Also in:
lkml
On Wed, 2003-05-28 at 01:08, Paul Mackerras wrote:
James Simmons writes:quoted
Applied. Tho it is strnage. You shouldn't need to call fb_set_var from the driver.It's just convenient to use fb_set_var to get the hardware set to the initial mode. Would it be better to call controlfb_check_var, controlfb_set_par, etc., directly?
I think we are supposed to rely on the console subsytem opening us thus doing a set_par() with the initial var rather than doing set_var ourselves, but I'm not too sure, I added those set_var at a time where I had incorrect results without, we may be able to remove them by now... Ben. ------------------------------------------------------- This SF.net email is sponsored by: ObjectStore. If flattening out C++ or Java code to make your application fit in a relational database is painful, don't do it! Check out ObjectStore. Now part of Progress Software. http://www.objectstore.net/sourceforge