Re: [PATCH] update valkyriefb driver

On Sat, 24 May 2003, Paul Mackerras wrote:

This patch updates the valkyriefb driver to the new API.  It compiles
OK, but I haven't been able to test it.  I have simplified the driver
quite a bit using the knowledge that there can only ever be one
valkyrie graphics adaptor in a system - it is the built-in graphics
adaptor on various ancient mac and powermac machines, and we access it
at a hard-coded address, so we can only handle one.

Thanks! It compiles fine without any warnings on m68k!

However, in addition you want to apply the patch below. macmodes.o is only
there for m68k (but it shouldn't harm for PPC), while you do need the cfb*.o
files on both platforms.

--- linux-2.5.69/drivers/video/Makefile	Tue Apr  8 10:05:26 2003
+++ linux-m68k-2.5.69/drivers/video/Makefile	Sun May 25 15:40:39 2003

@@ -26,7 +26,7 @@
 obj-$(CONFIG_FB_IGA)              += igafb.o cfbfillrect.o cfbcopyarea.o cfbimgblt.o
 obj-$(CONFIG_FB_CONTROL)          += controlfb.o
 obj-$(CONFIG_FB_PLATINUM)         += platinumfb.o
-obj-$(CONFIG_FB_VALKYRIE)         += valkyriefb.o
+obj-$(CONFIG_FB_VALKYRIE)         += valkyriefb.o macmodes.o cfbfillrect.o cfbcopyarea.o cfbimgblt.o
 obj-$(CONFIG_FB_CT65550)          += chipsfb.o cfbfillrect.o cfbcopyarea.o cfbimgblt.o
 obj-$(CONFIG_FB_ANAKIN)           += anakinfb.o cfbfillrect.o cfbcopyarea.o cfbimgblt.o
 obj-$(CONFIG_FB_CLPS711X)         += clps711xfb.o cfbfillrect.o cfbcopyarea.o cfbimgblt.o

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds