RE: [PATCH 2.5.68] Epson 1355 Rewrite for 2.5
From: James Simmons <hidden>
Date: 2003-05-07 21:58:34
Personally, I think it wouldn't harm to be make the cfb* routines generic, so you can set some defines and #include them to tailer them to your card's needs. Even on some 64-bit platforms, you may not want to use 64-bit accesses, e.g. because your graphic's card bus is still only 32-bit. I can even think of some more sofistication: on older Amigas, the graphics RAM is 16-bit wide and quite slow, while the CPU is 32-bit. So it may make sense to always use 32-bit accesses (like is currently done), except for the first and last unaligned accesses if they are less or equal than 16-bit.
I have put alot of though and even tested some raw code for this. The issue with just replacing the FB_WRITE and FB_READ stuff is more than one card could be present and each would require a different FB_WRITE. This would conflict. So what do we do? Ah the answer is use struct pixmap to handle it. I just reworked cfbimgblt.c to use struct pixmap and I am in the process of of working on the other cfb_* functions. Would you be willing to test this out? In theory one would only have to place in there own FB_WRITE[READ] function. ------------------------------------------------------- Enterprise Linux Forum Conference & Expo, June 4-6, 2003, Santa Clara The only event dedicated to issues related to Linux enterprise solutions www.enterpriselinuxforum.com