Re: Much better framebuffer fixes.
From: Antonino Daplas <hidden>
Date: 2003-03-27 19:22:52
Also in:
lkml
On Thu, 2003-03-27 at 17:18, Geert Uytterhoeven wrote:
On Thu, 27 Mar 2003, James Simmons wrote:quoted
drivers/video/logo/logo.c | 69 +++++------Are you sure the change from logo type to logo depth in (fb_)find_logo() won't have any side effects? After this change, you may receive a different type of logo than you requested.
I agree. Take the case of Directcolor. At 16-bpp, it needs linux_logo_vga16, not linux_logo_clut224. Also, monochrome at 8bpp needs linux_logo_mono, certainly not linux_logo_clut224. There are obviously other similar cases. I think the original logo code in both logo.c and fbmem.c, though a bit more confusing, provides better ways of choosing the correct logo. Tony ------------------------------------------------------- This SF.net email is sponsored by: The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today! http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en