On Tue, Mar 25 2003, James Simmons wrote:

As usually I have a patch avalaible at 

http://phoenix.infradead.org/~jsimmons/fbdev.diff.gz

 drivers/video/aty/aty128fb.c  |   16 +++++++---------
 drivers/video/console/fbcon.c |    4 ++--
 drivers/video/controlfb.c     |   18 +++---------------
 drivers/video/platinumfb.c    |   28 ++++++++--------------------
 drivers/video/radeonfb.c      |   10 ++++++++++
 drivers/video/softcursor.c    |    2 +-
 6 files changed, 31 insertions(+), 47 deletions(-)

The patch has updates for the ATI Rage 128, Control, and Platnium 
framebuffer driver. The Radeon patch adds PLL times for the R* series of
cards. Memory is now safe to allocate for the software cursor and inside 
fbcon. There still are issues with syncing which cause the cursor on some 
systems to become corrupt sometimes. 

-       data = kmalloc(size, GFP_KERNEL);
-       mask = kmalloc(size, GFP_KERNEL);
+       data = kmalloc(size, GFP_ATOMIC);
+       mask = kmalloc(size, GFP_ATOMIC);

        if (cursor->set & FB_CUR_SETSIZE) {
                memset(data, 0xff, size);


irk, you replaced GFP_KERNEL with GFP_ATOMIC, and even unconditionally
memset the return without even bothering to check if it succeeded or
not.

-- 
Jens Axboe



-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en