Thread (8 messages) 8 messages, 3 authors, 2003-03-25

Re: PPC64 prom logo

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2003-03-24 19:22:24

On Mon, 24 Mar 2003, James Simmons wrote:
quoted
--- linux-2.5.x/arch/ppc64/kernel/prom.c.orig	Sun Mar 23 11:37:52 2003
+++ linux-2.5.x/arch/ppc64/kernel/prom.c	Sun Mar 23 11:39:35 2003
@@ -1271,7 +1271,8 @@
 
 #ifdef CONFIG_FB_LOGO_LINUX_CLUT224
 		clut = RELOC(RELOC(&logo_linux_clut224)->clut);
-		for (i = 0; i < logo_linux_clut224.clutsize; i++, clut += 3)
+		for (i = 0; i < RELOC(&logo_linux_clut224)->clutsize;
+		     i++, clut += 3)
 			if (prom_set_color(ih, i + 32, clut[0], clut[1],
 					   clut[2]) != 0)
 				break;
Shoudln't that be clut = RELOC(&logo_linux_clut2 instead?
I don't think so. First the logo_linux_clut224 symbol has to be relocated,
followed by the pointer to the CLUT.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help