Re: fb_imageblit semantic

On 17 Mar 03 at 11:31, Geert Uytterhoeven wrote:

On 17 Mar 2003, Antonino Daplas wrote:

quoted

As Geert said, it's not just trivial, but logical to split fb_imageblit
into two.

So, are we gonna split it? This will also make hardware acceleration support
more clean. E.g. most sbus drivers do color expansion in hardware, and fall
back to cfb_imageblit() for the logo.

quoted

quoted

OK, so rule is that if depth=0, input is 1bpp with palette in bgcol/fgcol,
while if depth != 0, then palette is in info->pseudo_palette ?

Yes.  You can also say that if image->depth != var->bits_per_pixel, do
color expansion or reduction, whatever the case may be.

Hmmm... Note that image->depth can be larger than 8, while the image data is
still 8-bit. This is an inconsistency.

image->depth for logo must change to 8. Or remove depth completely after
splitting imageblit to paintchar & paintlogo, as currently depth is
useless anyway: target format is defined by framebuffer layout, not
by image->depth, and source format is hardwired to the code.
                                                        Petr Vandrovec
                                                        vandrove@vc.cvut.cz



-------------------------------------------------------
This SF.net email is sponsored by:Crypto Challenge is now open! 
Get cracking and register here for some mind boggling fun and 
the chance of winning an Apple iPod:
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0031en