Re: [Linux-fbdev-devel] [PATCH][FBDEV]: fb_putcs() and fb_setfont() methods
From: Petr Vandrovec <hidden>
Date: 2003-01-04 23:22:14
Also in:
lkml
On Sat, Jan 04, 2003 at 09:07:29PM +0000, James Simmons wrote:
Rejected. I have put thought into it and the whole point was to not allow the fbdev layer to touch console data. I stand firm on this!!! The reason being is the core console layer is going to change the next development cycle. We have to change to deal with things like the PC9800 type hardware that support more than 512 fonts. Do we realy want to break every fbdev driver again. This way the breakage is once and for all. Its is also a
Why? (a) only those which will use putcs, and (b) I see no 512 chars limit anywhere in new code. And in old code it is there only because of passed data are only 16bit, not 32bit wide... With simple search&replace you can extend it to any size you want, as long as you'll not use sparse font bitmap.
pandoras box. If we place these hooks in we end up with the same crappy driver problem we had before. I never heard anyone every say the old api we clean.
I believe that I repeatedly said that I see no problem with old API which cannot be solved by incremental updates and without removing functionality. It is like with modules - some believe in evolution, and some in revolution... Fortunately modules situation finally settled down and it is enough just install new app to handle module loading/unloading. With current fbdev even trivial console resizing does not do anything useful (thanks, Antonio). Best regards, Petr Vandrovec vandrove@vc.cvut.cz