Re: [PATCH] inivisible cursor on vesafb

On Mon, 2002-08-19 at 07:05, Petr Vandrovec wrote:

Hi Linus,

Since vesafb was converted to the (strange) cfb* interface, it uses random
colors for the cursor, making cursor invisible when console uses black foreground
(f.e. Midnight Commander does that). Problem is common to all fbdevs which
use fbcon-accel interface.

This change tries to restore old behavior which existed before cfb* came in.
Unfortunately due to region.color semantic it is not possible to completely
restore previous behavior - 
+ for truecolor cfbfillrect always consults current palette, so we do not 
  have "always invert" constant available, and so we do inversion with palette
  color 15 (it is light white, ~0, by default)
+ for directcolor it assumes that display has at least 4 bits per color.
+ for pseudocolor it works as old code worked.

I think it has been agreed that all color entries in fbcon-accel should
always be an index to the pseudopalette regardless of the visuals.  So a
more consistent change is to have cfbfillrect look up the color from the
pseudopalette assuming that the driver correctly loaded the value to the
pseudopalette.