Re: [PATCH] fbdev updates.

On Thu, Jul 04, 2002 at 09:05:40PM -0700, James Simmons wrote:

quoted

2. I've no idea why you moved "lccr0" and "lccr3" in sa1100fb.h - this
   looks like noise to me.

Ah the idea of a par and using generic struct fb_info. A few reasons. One
I noticed people having fields inside their struct xxxfb_info that was
already there in the generic struct fb_info. By making a strick rule I
hope to avoid that ugly mess. The second reason is eventually I like to
combine DRI and the fbdev layer. This was both interfaces could use the
same struct xxx_par. That is a 2.7 thing but I like to prepare now for
this. For the SA1100 this is not really needed but I still like to enforce
this rule and we still can take advantage of the nice generic functions in
fbgen.c.

First, I detest the idea of "fix", "var", "par" and "info".  Specifically
the "par" crap.  Intensely.  "par" and "info" should be combined IMO,
which my framebuffer drivers do.

Secondly, I think you're completely confused above.  lccr0 and lccr3 have
nothing to do with some "generic struct fb_info".  They hold the base
register values for two of the SA1100 control registers.

Thirdly, you didn't delete them.  You _moved_ them within the structure.
They therefore served zero functional purpose.

Fourthly, nothing but the sa1100fb driver has any business accessing the
elements around these two both before and after the move.

In total, the change serves ZERO purpose and is therefore noise.

quoted

5. I strongly disagree with your apparant decision to make the cpufreq
   part of the generic framebuffer core (by apparantly adding the notifier
   block to the core fb_info structure).  Firstly, you've broken sa1100fb.c
   by not including the relevant definition in fb_info (ok, so cpufreq
   stuff isn't in Linus' tree yet).  Secondly, it isn't something that all
   framebuffers require; its only required on SoC devices where the hardware
   designers have been stingy.  As such, we should NOT penalise the x86
   people by adding random useless garbage to structures that they're never
   going to use.

I completely agree. I'm going to remove that. Originally I thought about
making it generic for everyone because I have seen other platforms
(Mips Au1000 with Epson 1385 framebuffers) do something similar. Then I
realized not everyone needs it and also it is possible that devices with
more than one framebuffer might use the same pixclock frequency.

Ehh?  That's got nothing to do with cpufreq.  The reason we have the
cpufreq interface in sa1100fb is that the base clock rate for the LCD
controller on this chip is derived from the CPU core clock.  You change
the core clock, you have to reprogram the pixel clock divisor.

Dumb but
I have seen alot of cards share the accel engine and/or CRTC registers
between two different framebuffers on the same piece of hardware. So it
belongs in par.

Again, I think this is another misplaced reason; that's irrelevant to
cpufreq.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Bringing you mounds of caffeinated joy.
http://thinkgeek.com/sf