Re: [PATCH v1 1/3] new: Add a new parameter (name/emailid) in the "new" script
From: Zorro Lang <hidden>
Date: 2025-05-14 05:36:53
Also in:
fstests, linux-xfs
On Tue, May 13, 2025 at 08:10:10AM +0000, Nirjhar Roy (IBM) wrote:
quoted hunk ↗ jump to hunk
This patch another optional interactive prompt to enter the author name and email id for each new test file that is created using the "new" file. The sample output looks like something like the following: ./new selftest Next test id is 007 Append a name to the ID? Test name will be 007-$name. y,[n]: Creating test file '007' Add to group(s) [auto] (separate by space, ? for list): selftest quick Enter <author_name> <email-id>: Nirjhar Roy [off-list ref] Creating skeletal script for you to edit ... done. ... ... Signed-off-by: Nirjhar Roy (IBM) <redacted> --- new | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)diff --git a/new b/new index 6b50ffed..139715bf 100755 --- a/new +++ b/new@@ -136,6 +136,9 @@ else check_groups "${new_groups[@]}" || exit 1 fi +read -p "Enter <author_name> <email-id>: " -r
I think most of "YOUR NAME HERE" are the name of company, e.g. "Oracle, Inc", "Red Hat, Inc". Some authors just write their names, e.g. "Filipe Manana", "Chao Yu"... So I think the "<email-id>" hint isn't necessary. If someone need that, he can write it with his name together. Thanks, Zorro
quoted hunk ↗ jump to hunk
+author_name="${REPLY:=YOUR NAME HERE}" + echo -n "Creating skeletal script for you to edit ..." year=`date +%Y`@@ -143,7 +146,7 @@ year=`date +%Y` cat <<End-of-File >$tdir/$id #! /bin/bash # SPDX-License-Identifier: GPL-2.0 -# Copyright (c) $year YOUR NAME HERE. All Rights Reserved. +# Copyright (c) $year $author_name. All Rights Reserved. # # FS QA Test $id #-- 2.34.1