Thread (31 messages) flat view 31 messages, 6 authors, 2023-09-07

Re: [PATCH 07/13] xfs: document the invalidate_bdev call in invalidate_bdev

From: Christoph Hellwig <hch@lst.de>
Date: 2023-08-10 15:54:18
Also in: linux-fsdevel, linux-xfs, ntfs3

On Wed, Aug 09, 2023 at 03:39:23PM -0700, Darrick J. Wong wrote:
quoted
+	 * read from the same page in the pagecache.
+	 *
+	 * The unmount writes updated inode metadata to disk directly.  The XFS
+	 * buffer cache does not use the bdev pagecache, nor does it invalidate
+	 * the pagecache on umount.  If the above scenario occurs, the pagecache
This sentence reads a little strangely, since "nor does it invalidate"
would seem to conflict with the invalidate_bdev call below.  I suggest
changing the verb a bit:

"The XFS buffer cache does not use the bdev pagecache, so it needs to
invalidate that pagecache on unmount."
Agreed. I'll forward it to the original author of the sentence time
permitting :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help