Re: [PATCHv3 0/4] submit_bh: Drop unnecessary return value

From
Theodore Ts'o <tytso@mit.edu>
Date
2022-09-29 14:59:13
Also in
linux-fsdevel
Reply to
Ritesh Harjani (IBM), 2022-08-18
On Thu, 18 Aug 2022 10:34:36 +0530, Ritesh Harjani (IBM) wrote:
submit_bh/submit_bh_wbc are non-blocking functions which just submits
the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait
on buffer till I/O completion and then check buffer head's b_state field
to know if there was any I/O error.

Hence there is no need for these functions to have any return type.
Even now they always returns 0. Hence drop the return value and make
their return type as void to avoid any confusion.

[...]
Applied, thanks!

[1/4] jbd2: Drop useless return value of submit_bh
      commit: c2939da1fe8b25c82c1991eb983638463ed84a0c
[2/4] fs/ntfs: Drop useless return value of submit_bh from ntfs_submit_bh_for_read
      commit: f102f1ab784c91c559a3505d024008ff2decc77f
[3/4] fs/buffer: Drop useless return value of submit_bh
      commit: 7cb83d3c0c485b3b035cdcac4c6ef4937f920c59
[4/4] fs/buffer: Make submit_bh & submit_bh_wbc return type as void
      commit: 54a55bcabb92f7522e006ca38575159c41914c56

Best regards,
-- 
Theodore Ts'o [off-list ref]
Thread (7 messages) 7 messages, 3 authors, last reply 2022-09-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help