Re: [PATCH 1/3] common/rc: move ext4-specific helpers into a separate common/ext4 file
flat view
From: Christoph Hellwig <hch@infradead.org>
Date: 2022-08-11 12:32:09
Also in:
fstests, linux-xfs
On Tue, Aug 09, 2022 at 02:00:46PM -0700, Darrick J. Wong wrote:
quoted hunk ↗ jump to hunk
--- a/common/config +++ b/common/config@@ -512,6 +512,10 @@ _source_specific_fs() ;; ext4) [ "$MKFS_EXT4_PROG" = "" ] && _fatal "mkfs.ext4 not found" + . ./common/ext4 + ;; + ext2|ext3|ext4dev) + . ./common/ext4
Not really new in this patch, but why does ext4 check for a specific mkfs and the others don't? Also can we drop ext4dev while we're at it? The patch itself looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>