Re: [PATCH 05/14] isofs: replace ll_rw_block()
flat view
From: Jan Kara <jack@suse.cz>
Date: 2022-08-31 10:53:15
Also in:
linux-fsdevel, lkml, ntfs3, ocfs2-devel
On Wed 31-08-22 15:21:02, Zhang Yi wrote:
ll_rw_block() is not safe for the sync read path because it cannot guarantee that submitting read IO if the buffer has been locked. We could get false positive EIO return from zisofs_uncompress_block() if he buffer has been locked by others. So stop using ll_rw_block(), switch to sync helper instead. Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza
quoted hunk ↗ jump to hunk
--- fs/isofs/compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c index b466172eec25..ac35eddff29c 100644 --- a/fs/isofs/compress.c +++ b/fs/isofs/compress.c@@ -82,7 +82,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, return 0; } haveblocks = isofs_get_blocks(inode, blocknum, bhs, needblocks); - ll_rw_block(REQ_OP_READ, haveblocks, bhs); + bh_read_batch(bhs, haveblocks); curbh = 0; curpage = 0;-- 2.31.1
-- Jan Kara [off-list ref] SUSE Labs, CR