On 2022/3/2 5:49, Yang Shi wrote:

On Tue, Mar 1, 2022 at 12:45 AM Miaohe Lin [off-list ref] wrote:

quoted

On 2022/3/1 7:57, Yang Shi wrote:

quoted

MMF_VM_HUGEPAGE is set as long as the mm is available for khugepaged by
khugepaged_enter(), not only when VM_HUGEPAGE is set on vma.  Correct
the comment to avoid confusion.

Signed-off-by: Yang Shi <redacted>
---
 include/linux/sched/coredump.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h
index 4d9e3a656875..4d0a5be28b70 100644
--- a/include/linux/sched/coredump.h
+++ b/include/linux/sched/coredump.h

@@ -57,7 +57,8 @@ static inline int get_dumpable(struct mm_struct *mm)
 #endif
                                      /* leave room for more dump flags */
 #define MMF_VM_MERGEABLE     16      /* KSM may merge identical pages */
-#define MMF_VM_HUGEPAGE              17      /* set when VM_HUGEPAGE is set on vma */
+#define MMF_VM_HUGEPAGE              17      /* set when mm is available for
+                                        khugepaged */

I think this comment could be written in one line. Anyway, this patch looks good to me.
Thanks.

Yes, as long as we don't care about the 80 characters limit. I know
the limit was bumped to 100 by checkpatch, but I have seen 80 was
still preferred by a lot of people.

I see. Many thanks for clarifying.

quoted

Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks.

quoted

quoted

 /*
  * This one-shot flag is dropped due to necessity of changing exe once again
  * on NFS restore

.