Thread (12 messages) 12 messages, 5 authors, 2022-02-05

Re: [PATCH 0/2] ext4: fast commit crash consistency issues

From: harshad shirwadkar <hidden>
Date: 2021-12-23 20:13:37
Also in: lkml

Thanks for the patches, these are good finds.

Reviewed-by: Harshad Shirwadkar <redacted>

On Wed, Dec 22, 2021 at 7:24 PM Xin Yin [off-list ref] wrote:
This patch sets fix 2 crash-consistency issues of fast commit.
First patch change to use ext4_ext_remove_space instead of
ext4_punch_hole during replay delete range procedure. This
avoid replay procedure being affeced by incorrect inode->i_size.
Second patch correct the trank range logic for ftruncte.

After testing this patch sets with xfstests-bld, in the "log" and
"quick" group with config "fast_commit" is selected. No regressions
was found.

Signed-off-by: Xin Yin <redacted>

Xin Yin (2):
  ext4: use ext4_ext_remove_space() for fast commit replay delete range
  ext4: fast commit may miss tracking unwritten range during ftruncate

 fs/ext4/fast_commit.c | 13 ++++++++-----
 fs/ext4/inode.c       |  3 +--
 2 files changed, 9 insertions(+), 7 deletions(-)

--
2.20.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help