[PATCH 1/6] e2fsck: set s->len=0 if malloc() fails in alloc_string()

[PATCH 0/6] solve memory leak and check whether NULL pointer · zhanchengbin <hidden> · 2021-12-03
[PATCH 1/6] e2fsck: set s->len=0 if malloc() fails in alloc_string() · zhanchengbin <hidden> · 2021-12-03
Re: [PATCH 1/6] e2fsck: set s->len=0 if malloc() fails in alloc_string() · Zhiqiang Liu <hidden> · 2021-12-03
[PATCH 2/6] lib/ss: check whether argp is null before accessing it in ss_execute_command() · zhanchengbin <hidden> · 2021-12-03
[PATCH 3/6] lib/support: check whether inump is null before accessing it in quota_set_sb_inum() · zhanchengbin <hidden> · 2021-12-03
[PATCH 4/6] e2fsprogs: call ext2fs_badblocks_list_free() to free list in exception branch · zhanchengbin <hidden> · 2021-12-03
[PATCH 5/6] e2fsck: check whether ldesc is null before accessing it in end_problem_latch() · zhanchengbin <hidden> · 2021-12-03
[PATCH 6/6] lib/ext2fs: call ext2fs_free_mem() to free &io->name in exception branch · zhanchengbin <hidden> · 2021-12-03

STALE1643d

From: zhanchengbin <hidden>
Date: 2021-12-03 06:26:20
Subsystem: the rest · Maintainer: Linus Torvalds

In alloc_string(), when malloc fails, len in the
string structure should be 0.

Signed-off-by: zhanchengbin <redacted>
Signed-off-by: Zhiqiang Liu <redacted>
---
  e2fsck/logfile.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/e2fsck/logfile.c b/e2fsck/logfile.c
index 63e9a12f..f2227ad5 100644
--- a/e2fsck/logfile.c
+++ b/e2fsck/logfile.c

@@ -32,6 +32,8 @@ static void alloc_string(struct string *s, int len)
  {
      s->s = malloc(len);
  /* e2fsck_allocate_memory(ctx, len, "logfile name"); */
+    if (s->s == NULL)
+        s->len = 0;
      s->len = len;
      s->end = 0;
  }

-- 
2.23.0

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help