Re: [PATCH v1 1/9] mm: add zone device coherent type memory support
From: Christoph Hellwig <hch@lst.de>
Date: 2021-11-17 09:51:06
Also in:
amd-gfx, linux-mm, linux-xfs
On Mon, Nov 15, 2021 at 01:30:18PM -0600, Alex Sierra wrote:
quoted hunk ↗ jump to hunk
@@ -5695,8 +5695,8 @@ static int mem_cgroup_move_account(struct page *page, * 2(MC_TARGET_SWAP): if the swap entry corresponding to this pte is a * target for charge migration. if @target is not NULL, the entry is stored * in target->ent. - * 3(MC_TARGET_DEVICE): like MC_TARGET_PAGE but page is MEMORY_DEVICE_PRIVATE - * (so ZONE_DEVICE page and thus not on the lru). + * 3(MC_TARGET_DEVICE): like MC_TARGET_PAGE but page is MEMORY_DEVICE_COHERENT + * or MEMORY_DEVICE_PRIVATE (so ZONE_DEVICE page and thus not on the lru).
Please avoid the overly long line. But I don't think we we need to mention the exact enum, but rather do something like: * 3(MC_TARGET_DEVICE): like MC_TARGET_PAGE but page is device memory and * thus not on the lru.
+ switch (pgmap->type) {
+ case MEMORY_DEVICE_PRIVATE:
+ case MEMORY_DEVICE_COHERENT:
/*
* TODO: Handle HMM pages which may need coordination
* with device-side memory.This might be a good opportunity for doing a s/HMM/device/ here.