Re: [PATCH 12/29] fsdax: remove a pointless __force cast in copy_cow_page_dax
From: "Darrick J. Wong" <djwong@kernel.org>
Date: 2021-11-23 22:33:28
Also in:
dm-devel, linux-fsdevel, linux-s390, linux-xfs, nvdimm
On Tue, Nov 09, 2021 at 09:32:52AM +0100, Christoph Hellwig wrote:
Despite its name copy_user_page expected kernel addresses, which is what we already have. Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D
quoted hunk ↗ jump to hunk
--- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/dax.c b/fs/dax.c index 4e3e5a283a916..73bd1439d8089 100644 --- a/fs/dax.c +++ b/fs/dax.c@@ -728,7 +728,7 @@ static int copy_cow_page_dax(struct block_device *bdev, struct dax_device *dax_d return rc; } vto = kmap_atomic(to); - copy_user_page(vto, (void __force *)kaddr, vaddr, to); + copy_user_page(vto, kaddr, vaddr, to); kunmap_atomic(vto); dax_read_unlock(id); return 0;-- 2.30.2