Re: [PATCH v4 4/9] syscalls/fanotify22: Validate the generic error info
From: Amir Goldstein <amir73il@gmail.com>
Date: 2021-11-19 05:38:57
Also in:
ltp
On Fri, Nov 19, 2021 at 1:58 AM Gabriel Krisman Bertazi [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Implement some validation for the generic error info record emitted by the kernel. The error number is fs-specific but, well, we only support ext4 for now anyway. Reviewed-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Gabriel Krisman Bertazi <redacted> --- Changes since v2: - check for error record type in autotools (Amir) Changes since v1: - Move defines to header file. --- configure.ac | 3 +- testcases/kernel/syscalls/fanotify/fanotify.h | 32 ++++++++++++++++ .../kernel/syscalls/fanotify/fanotify22.c | 37 ++++++++++++++++++- 3 files changed, 70 insertions(+), 2 deletions(-)diff --git a/configure.ac b/configure.ac index 859aa9857021..a9dc2524966d 100644 --- a/configure.ac +++ b/configure.ac@@ -160,7 +160,8 @@ AC_CHECK_MEMBERS([struct utsname.domainname],,,[ AC_CHECK_TYPES([enum kcmp_type],,,[#include <linux/kcmp.h>]) AC_CHECK_TYPES([struct acct_v3],,,[#include <sys/acct.h>]) AC_CHECK_TYPES([struct af_alg_iv, struct sockaddr_alg],,,[# include <linux/if_alg.h>]) -AC_CHECK_TYPES([struct fanotify_event_info_fid, struct fanotify_event_info_header],,,[#include <sys/fanotify.h>]) +AC_CHECK_TYPES([struct fanotify_event_info_fid, struct fanotify_event_info_header, + struct fanotify_event_info_error],[],[],[#include <sys/fanotify.h>])
Doh! it seems like fanotify_event_info_pidfd was dropped between v2 -> v3 in Matthew's patches. Petr, Can you please fix this. Thanks, Amir.