Re: [PATCH 06/11] xfs: factor out a xfs_setup_dax helper

On Tue, Oct 19, 2021 at 12:24 AM Christoph Hellwig [off-list ref] wrote:

On Mon, Oct 18, 2021 at 09:43:51AM -0700, Darrick J. Wong wrote:

quoted

quoted

--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c

@@ -339,6 +339,32 @@ xfs_buftarg_is_dax(
                    bdev_nr_sectors(bt->bt_bdev));
 }

+static int
+xfs_setup_dax(

/me wonders if this should be named xfs_setup_dax_always, since this
doesn't handle the dax=inode mode?

Sure, why not.

I went ahead and made that change locally.

quoted

The only reason I bring that up is that Eric reminded me a while ago
that we don't actually print any kind of EXPERIMENTAL warning for the
auto-detection behavior.

Yes, I actually noticed that as well when preparing this series.

The rest looks good to me.