Re: don't use ->bd_inode to access the block device size

don't use ->bd_inode to access the block device size · Christoph Hellwig <hch@lst.de> · 2021-10-13
[PATCH 01/29] bcache: remove bdev_sectors · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 01/29] bcache: remove bdev_sectors · Coly Li <hidden> · 2021-10-13
Re: [PATCH 01/29] bcache: remove bdev_sectors · Kees Cook <hidden> · 2021-10-13
[PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it · Kees Cook <hidden> · 2021-10-13
Re: [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it · Chaitanya Kulkarni <hidden> · 2021-10-13
[PATCH 03/29] dm: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 03/29] dm: use bdev_nr_sectors instead of open coding it · Kees Cook <hidden> · 2021-10-13
Re: [PATCH 03/29] dm: use bdev_nr_sectors instead of open coding it · Mike Snitzer <hidden> · 2021-10-13
[PATCH 04/29] md: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it · Kees Cook <hidden> · 2021-10-13
Re: [PATCH 04/29] md: use bdev_nr_sectors instead of open coding it · Song Liu <song@kernel.org> · 2021-10-13
[PATCH 05/29] mtd/block2mtd: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
[PATCH 06/29] nvmet: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 06/29] nvmet: use bdev_nr_sectors instead of open coding it · Chaitanya Kulkarni <hidden> · 2021-10-13
[PATCH 07/29] target/iblock: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 07/29] target/iblock: use bdev_nr_sectors instead of open coding it · Bodo Stroesser <bostroesser@gmail.com> · 2021-10-13
Re: [PATCH 07/29] target/iblock: use bdev_nr_sectors instead of open coding it · Chaitanya Kulkarni <hidden> · 2021-10-13
[PATCH 08/29] fs: use bdev_nr_sectors instead of open coding it in blkdev_max_block · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 08/29] fs: use bdev_nr_sectors instead of open coding it in blkdev_max_block · Jan Kara <jack@suse.cz> · 2021-10-13
Re: [PATCH 08/29] fs: use bdev_nr_sectors instead of open coding it in blkdev_max_block · Chaitanya Kulkarni <hidden> · 2021-10-13
[PATCH 09/29] fs: simplify init_page_buffers · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 09/29] fs: simplify init_page_buffers · Kees Cook <hidden> · 2021-10-13
Re: [PATCH 09/29] fs: simplify init_page_buffers · Jan Kara <jack@suse.cz> · 2021-10-13
[PATCH 10/29] affs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 10/29] affs: use bdev_nr_sectors instead of open coding it · Kees Cook <hidden> · 2021-10-13
[PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it · Anand Jain <hidden> · 2021-10-13
Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it · Chaitanya Kulkarni <hidden> · 2021-10-13
Re: [PATCH 11/29] btrfs: use bdev_nr_sectors instead of open coding it · Keith Busch <kbusch@kernel.org> · 2021-10-14
[PATCH 12/29] cramfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 12/29] cramfs: use bdev_nr_sectors instead of open coding it · Kees Cook <hidden> · 2021-10-13
[PATCH 13/29] fat: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 13/29] fat: use bdev_nr_sectors instead of open coding it · Kees Cook <hidden> · 2021-10-13
[PATCH 14/29] hfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 14/29] hfs: use bdev_nr_sectors instead of open coding it · Kees Cook <hidden> · 2021-10-13
[PATCH 15/29] hfsplus: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 15/29] hfsplus: use bdev_nr_sectors instead of open coding it · Kees Cook <hidden> · 2021-10-13
[PATCH 16/29] jfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 16/29] jfs: use bdev_nr_sectors instead of open coding it · Dave Kleikamp <hidden> · 2021-10-13
[PATCH 17/29] nfs/blocklayout: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
[PATCH 18/29] nilfs2: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
[PATCH 19/29] ntfs3: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
[PATCH 20/29] pstore/blk: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
[PATCH 21/29] reiserfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 21/29] reiserfs: use bdev_nr_sectors instead of open coding it · Jan Kara <jack@suse.cz> · 2021-10-13
[PATCH 22/29] squashfs: use bdev_nr_sectors instead of open coding it · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 22/29] squashfs: use bdev_nr_sectors instead of open coding it · Phillip Lougher <phillip@squashfs.org.uk> · 2021-10-13
[PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate · Jan Kara <jack@suse.cz> · 2021-10-13
Re: [PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate · Chaitanya Kulkarni <hidden> · 2021-10-13
[PATCH 24/29] block: add a sb_bdev_nr_blocks helper · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 24/29] block: add a sb_bdev_nr_blocks helper · Kees Cook <hidden> · 2021-10-13
[PATCH 25/29] ext4: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 25/29] ext4: use sb_bdev_nr_blocks · Kees Cook <hidden> · 2021-10-13
Re: [PATCH 25/29] ext4: use sb_bdev_nr_blocks · Kees Cook <hidden> · 2021-10-13
Re: [PATCH 25/29] ext4: use sb_bdev_nr_blocks · Jan Kara <jack@suse.cz> · 2021-10-13
Re: [PATCH 25/29] ext4: use sb_bdev_nr_blocks · "Theodore Ts'o" <tytso@mit.edu> · 2021-10-13
[PATCH 26/29] jfs: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 26/29] jfs: use sb_bdev_nr_blocks · Kees Cook <hidden> · 2021-10-13
[PATCH 27/29] ntfs: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 27/29] ntfs: use sb_bdev_nr_blocks · Kees Cook <hidden> · 2021-10-13
[PATCH 28/29] reiserfs: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 28/29] reiserfs: use sb_bdev_nr_blocks · Kees Cook <hidden> · 2021-10-13
Re: [PATCH 28/29] reiserfs: use sb_bdev_nr_blocks · Jan Kara <jack@suse.cz> · 2021-10-13
[PATCH 29/29] udf: use sb_bdev_nr_blocks · Christoph Hellwig <hch@lst.de> · 2021-10-13
Re: [PATCH 29/29] udf: use sb_bdev_nr_blocks · Kees Cook <hidden> · 2021-10-13
Re: [PATCH 29/29] udf: use sb_bdev_nr_blocks · Jan Kara <jack@suse.cz> · 2021-10-13
Re: don't use ->bd_inode to access the block device size · Kees Cook <hidden> · 2021-10-13
Re: don't use ->bd_inode to access the block device size · Anand Jain <hidden> · 2021-10-13
Re: don't use ->bd_inode to access the block device size · Christoph Hellwig <hch@lst.de> · 2021-10-14
Re: don't use ->bd_inode to access the block device size · Anton Altaparmakov <hidden> · 2021-10-14
Re: don't use ->bd_inode to access the block device size · Dave Kleikamp <hidden> · 2021-10-14
Re: don't use ->bd_inode to access the block device size · Kees Cook <hidden> · 2021-10-14
Re: don't use ->bd_inode to access the block device size · Wol <hidden> · 2021-10-14

From: Christoph Hellwig <hch@lst.de>
Date: 2021-10-14 06:28:54
Also in: dm-devel, linux-bcache, linux-block, linux-btrfs, linux-fsdevel, linux-nfs, linux-nvme, linux-raid, linux-scsi, ntfs3, target-devel

On Wed, Oct 13, 2021 at 07:10:13AM +0200, Christoph Hellwig wrote:

I wondered about adding a helper for looking at the size in byte units
to avoid the SECTOR_SHIFT shifts in various places.  But given that
I could not come up with a good name and block devices fundamentally
work in sector size granularity I decided against that.

So it seems like the biggest review feedback is that we should have
such a helper.  I think the bdev_size name is the worst as size does
not imply a particular unit.  bdev_nr_bytes is a little better but I'm
not too happy.  Any other suggestions or strong opinions?

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help