Re: [PATCH v2 08/10] syscalls/fanotify20: Test event after filesystem abort
From: Amir Goldstein <amir73il@gmail.com>
Date: 2021-10-27 09:56:30
Also in:
ltp
On Tue, Oct 26, 2021 at 9:44 PM Gabriel Krisman Bertazi [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This test monitors the error triggered after a file system abort. It works by forcing a remount with the option "abort". This is an error not related to a file so it is reported against the superblock with a zero size fh. Signed-off-by: Gabriel Krisman Bertazi <redacted> --- testcases/kernel/syscalls/fanotify/fanotify20.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)diff --git a/testcases/kernel/syscalls/fanotify/fanotify20.c b/testcases/kernel/syscalls/fanotify/fanotify20.c index 298bb303a810..5c5ee3c6fb74 100644 --- a/testcases/kernel/syscalls/fanotify/fanotify20.c +++ b/testcases/kernel/syscalls/fanotify/fanotify20.c@@ -57,6 +57,12 @@ static void do_debugfs_request(const char *dev, char *request) SAFE_CMD(cmd, NULL, NULL); } +static void trigger_fs_abort(void) +{ + SAFE_MOUNT(tst_device->dev, MOUNT_PATH, tst_device->fs_type, + MS_REMOUNT|MS_RDONLY, "abort"); +} + static struct test_case { char *name; int error;@@ -64,6 +70,13 @@ static struct test_case { struct fanotify_fid_t *fid; void (*trigger_error)(void); } testcases[] = { + { + .name = "Trigger abort", + .trigger_error = &trigger_fs_abort, + .error_count = 1, + .error = ESHUTDOWN, + .fid = &null_fid, + }, };
I suppose you did not try to run fanotify20 -i 10 ...? I guess you will need to end the setup() stage with unmounted fs and perform: mount; fanotify_init; fanotify_mark; at beginning of do_test() finishing do_test() with closing fanotify fd and unmount. I never checked it there are pre-test/post-test callbacks available in LTP, but setup/clean are called at start/end of test loop. Thanks, Amir.