Thread (11 messages) 11 messages, 2 authors, 2021-10-21

Re: [RFC PATCH 3/3] ext4: prevent partial update of the extent blocks

From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-10-07 16:45:21

On Wed, Sep 08, 2021 at 08:08:50PM +0800, Zhang Yi wrote:
In the most error path of current extents updating operations are not
roll back partial updates properly when some bad things happens(.e.g in
ext4_ext_insert_extent()). So we may get an inconsistent extents tree
if journal has been aborted due to IO error, which may probability lead
to BUGON later when we accessing these extent entries in errors=continue
mode. This patch drop extent buffer's verify flag before updatng the
contents in ext4_ext_get_access(), and reset it after updating in
__ext4_ext_dirty(). After this patch we could force to check the extent
buffer if extents tree updating was break off, make sure the extents are
consistent.

Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Looks good, thanks

Reviewed-by: Theodore Ts'o <tytso@mit.edu>

						- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help