Re: [PATCH V3 5/5] ext4: make fallocate retry when err is ENOSPC

On Wed 04-08-21 17:32:21, Jan Kara wrote:

On Sat 24-07-21 15:41:24, Wang Jianchao wrote:

quoted

From: Wang Jianchao <redacted>

The blocks may be waiting for journal commit to be freed back to
mb buddy. Let fallocate wait and retry in that case.

Signed-off-by: Wang Jianchao <redacted>

Did you really observe this? Because the retry is already handled in
ext4_alloc_file_blocks() that's used by ext4_fallocate(). So no retry
should be needed there.

Oh, I can see you've addressed these already in another reply. I'll comment
there.

								Honza
-- 
Jan Kara [off-list ref]
SUSE Labs, CR