Thread (12 messages) flat view 12 messages, 2 authors, 2021-08-31

Re: [PATCH v4 2/6] ext4: remove an unnecessary if statement in __ext4_get_inode_loc()

From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-08-31 03:04:39

On Thu, Aug 26, 2021 at 09:04:08PM +0800, Zhang Yi wrote:
The "if (!buffer_uptodate(bh))" hunk covered almost the whole code after
getting buffer in __ext4_get_inode_loc() which seems unnecessary, remove
it and switch to check ext4_buffer_uptodate(), it simplify code and make
it more readable.

Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help