Thread (16 messages) flat view 16 messages, 2 authors, 2021-08-11

Re: [PATCH 3/7] e2fsprogs: fix unexpected NULL variable

From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-08-10 15:01:37

On Fri, Aug 06, 2021 at 11:58:16AM +0200, Lukas Czerner wrote:
The ext2fs_check_mount_point() function can be called with mtpt being
NULL as for example from ext2fs_check_if_mounted(). However in the
is_swap_device condition we use the mtpt in strncpy without checking
whether it is non-null first.

This should not be a problem on linux since the previous attempt to open
the device exclusively would have prevented us from ever reaching the
problematic strncpy. However it's still a bug and can cause problems on
other systems, fix it by conditioning strncpy on mtpt not being null.

Signed-off-by: Lukas Czerner <redacted>
Applied, thanks.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help