[PATCH] ext4: remove conflict comment from __ext4_forget

Subsystems: ext4 file system, filesystems (vfs and infrastructure), the rest

STALE1873d LANDED: 9 (9M)

1 review trailer (1 from subsystem maintainers); landed in mainline as 73dc707161a8 on 2021-07-23.

2 messages, 2 authors, 2021-07-23 · open the first message on its own page

[PATCH] ext4: remove conflict comment from __ext4_forget

From: Guoqing Jiang <hidden>
Date: 2021-07-14 06:00:05

From: Guoqing Jiang <redacted>

We do a bforget and return for no journal case, so let's remove this
conflict comment.

Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Guoqing Jiang <redacted>
---
Change from RFC: add Jan's Reviewed-by.

 fs/ext4/ext4_jbd2.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c
index be799040a415..6e224b19eae7 100644
--- a/fs/ext4/ext4_jbd2.c
+++ b/fs/ext4/ext4_jbd2.c
@@ -244,9 +244,6 @@ int __ext4_journal_get_write_access(const char *where, unsigned int line,
  * "bh" may be NULL: a metadata block may have been freed from memory
  * but there may still be a record of it in the journal, and that record
  * still needs to be revoked.
- *
- * If the handle isn't valid we're not journaling, but we still need to
- * call into ext4_journal_revoke() to put the buffer head.
  */
 int __ext4_forget(const char *where, unsigned int line, handle_t *handle,
 		  int is_metadata, struct inode *inode,
-- 
2.25.1

Re: [PATCH] ext4: remove conflict comment from __ext4_forget

From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-07-23 11:33:33

On Wed, Jul 14, 2021 at 01:59:40PM +0800, Guoqing Jiang wrote:
From: Guoqing Jiang <redacted>

We do a bforget and return for no journal case, so let's remove this
conflict comment.

Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Guoqing Jiang <redacted>
Thanks, applied.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help