Re: [PATCH 1/6] libext2fs: improve jbd_debug() implementation
From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-07-07 02:38:59
From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-07-07 02:38:59
On Tue, Jun 15, 2021 at 09:53:29PM -0700, Eric Biggers wrote:
From: Eric Biggers <redacted>
Make jbd_debug() do format string checking (but still get compiled away
to nothing) when --enable-jbd-debug isn't specified, similar to
commit d556435156b7 ("jbd2: avoid -Wempty-body warnings") on the kernel
side. This should prevent --enable-jbd-debug from getting broken due to
bad jbd_debug() statements. It also eliminates a -Wunused-variable
warning where a variable was only used in a jbd_debug() statement.
Also remove an alternative definition of jbd_debug() that was
conditional on CONFIG_JBD_DEBUG && !CONFIG_JBD_DEBUG, so was dead code.
Signed-off-by: Eric Biggers <redacted>Thanks, applied. - Ted