Re: [PATCH] ext4: fix input checking in fs/jbd2/journal.c
From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-06-24 14:17:19
From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-06-24 14:17:19
On Mon, Jun 07, 2021 at 05:55:58PM +0000, Leah Rumancik wrote:
Update if (JBD2_JOURNAL_FLUSH_DISCARD & !blk_queue_discard(q)) to use && instead of &. JBD2_JOURNAL_FLUSH_DISCARD is set to 1 so & technically works but && could be a bit faster and will maintain correctness in the event the value of JBD2_JOURNAL_FLUSH_DISCARD is updated. Reported-by: kernel test robot <redacted> Reported-by: Dan Carpenter <redacted> Signed-off-by: Leah Rumancik <redacted>
Thanks, I've folded this fix into the base commit. - Ted