Re: [PATCH] jbd2: clean up misleading comments for jbd2_fc_release_bufs
From: Jan Kara <jack@suse.cz>
Date: 2021-06-09 08:56:32
On Tue 08-06-21 22:12:36, yangerkun wrote:
This comments was for jbd2_fc_wait_bufs, not for jbd2_fc_release_bufs. Remove this misleading comments. Signed-off-by: yangerkun <redacted>
Good point! Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza
quoted hunk ↗ jump to hunk
--- fs/jbd2/journal.c | 8 -------- 1 file changed, 8 deletions(-)diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 2dc944442802..ea46e5ad6b59 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c@@ -934,10 +934,6 @@ int jbd2_fc_wait_bufs(journal_t *journal, int num_blks) } EXPORT_SYMBOL(jbd2_fc_wait_bufs); -/* - * Wait on fast commit buffers that were allocated by jbd2_fc_get_buf - * for completion. - */ int jbd2_fc_release_bufs(journal_t *journal) { struct buffer_head *bh;@@ -945,10 +941,6 @@ int jbd2_fc_release_bufs(journal_t *journal) j_fc_off = journal->j_fc_off; - /* - * Wait in reverse order to minimize chances of us being woken up before - * all IOs have completed - */ for (i = j_fc_off - 1; i >= 0; i--) { bh = journal->j_fc_wbuf[i]; if (!bh)-- 2.31.1
-- Jan Kara [off-list ref] SUSE Labs, CR