Re: [PATCH 03/11] mm: Protect operations adding pages to page cache with invalidate_lock
From: Matthew Wilcox <willy@infradead.org>
Date: 2021-05-12 14:21:46
Also in:
ceph-devel, linux-cifs, linux-f2fs-devel, linux-fsdevel, linux-mm, linux-xfs
On Wed, May 12, 2021 at 03:46:11PM +0200, Jan Kara wrote:
quoted hunk ↗ jump to hunk
diff --git a/mm/truncate.c b/mm/truncate.c index 57a618c4a0d6..93bde2741e0e 100644 --- a/mm/truncate.c +++ b/mm/truncate.c@@ -415,7 +415,7 @@ EXPORT_SYMBOL(truncate_inode_pages_range); * @mapping: mapping to truncate * @lstart: offset from which to truncate * - * Called under (and serialised by) inode->i_rwsem. + * Called under (and serialised by) inode->i_rwsem and inode->i_mapping_rwsem.
mapping->invalidate_lock, surely? And could we ask lockdep to assert this for us instead of just a comment?
* * Note: When this function returns, there can be a page in the process of * deletion (inside __delete_from_page_cache()) in the specified range. Thus -- 2.26.2