Hello.

Andreas, thank you for the review. 
It looks like remarks don’t require v6 and can be fixed during a merge.

Does anybody has other any objections/ideas?

Thanks.
Artem Blagodarenko.

On 23 Apr 2021, at 19:25, Andreas Dilger [off-list ref] wrote:

On Apr 23, 2021, at 07:30, Artem Blagodarenko [off-list ref] wrote:

quoted

Add extended "-E ignore_error" option to be more tolerant
to fs errors while scanning inode extents.

Not to be pedantic, but should this allow "ignore_errors", since it will
presumably ignore more than one error.  If already using "ignore_error"
in the field you could accept both for some time until able to change over,
as we've done with "ea_inode" vs. "large_xattr" in the Lustre e2fsprogs
for years. 

quoted

Changes since preveious version:
- rebased on top of the master

This should go after the "---" so that it isn't in the final commit message. 

quoted

Signed-off-by: Alexey Lyashkov <redacted>
Signed-off-by: Artem Blagodarenko <redacted>
Cray-bug-id: LUS-1922
Change-Id: Ib79300656726839b1d3b7ee1dd0793c60679d296
Reviewed-by: Andreas Dilger <redacted>
---

One typo in the man page below:

quoted

diff --git a/misc/e2image.8.in b/misc/e2image.8.in
index cb176f5d..45a06d3b 100644
--- a/misc/e2image.8.in
+++ b/misc/e2image.8.in

@@ -137,6 +144,16 @@ useful if the file system is being cloned to a flash-based storage device

(where reads are very fast and where it is desirable to avoid unnecessary
writes to reduce write wear on the device).
.TP
+.BI \-E " extended_options"
+Set e2iamge extended options.

"e2image"

Ted could fix this in the final commit
Cheers, Andreas

quoted

Extended options are comma separated, and
+may take an argument using the equals ('=') sign.  The following options
+are supported:
+.RS 1.2i
+.TP
+.BI ignore_error
+Grab an image from a corrupted FS and ignore fs errors.
+.RE
+.TP
.B \-f
Override the read-only requirement for the source filesystem when saving
the image file using the