Thread (19 messages) 19 messages, 6 authors, 2021-04-23

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

From: Matthieu Baerts <hidden>
Date: 2021-04-14 09:25:32
Also in: linux-m68k, lkml, mptcp, netdev

Hi Nico,

On 14/04/2021 10:58, Nico Pache wrote:
Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the
KUNIT *_KUNIT_TEST config name format.
For MPTCP, we have multiple KUnit tests: crypto and token. That's why we 
wrote TESTS with a S.

I'm fine without S if we need to stick with KUnit' standard. But maybe 
the standard wants us to split the two tests and create 
MPTCP_TOKEN_KUNIT_TEST and MPTCP_TOKEN_KUNIT_TEST config?

In this case, we could eventually keep MPTCP_KUNIT_TESTS which will in 
charge of selecting the two new ones.

Up to the KUnit maintainers to decide ;-)

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help