Re: [PATCH] ext4: fix potential error in ext4_do_update_inode

On Fri, Mar 12, 2021 at 01:50:55PM +0100, Jan Kara wrote:

On Fri 12-03-21 01:50:51, Shijie Luo wrote:

quoted

If set_large_file = 1 and errors occur in ext4_handle_dirty_metadata(),
the error code will be overridden, go to out_brelse to avoid this
situation.

Signed-off-by: Shijie Luo <redacted>

Yeah, looks good. Once ext4_handle_dirty_metadata() fails, the journal is
aborted anyway so we are unlikely to do anything useful with the
filesystem. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

Thanks, applied.

					- Ted