Thread (4 messages) 4 messages, 3 authors, 2021-04-02

Re: [PATCH] misc: remove useless code in set_inode_xattr()

From: Zhiqiang Liu <hidden>
Date: 2021-03-03 15:19:05

ping...

On 2021/2/26 9:22, Zhiqiang Liu wrote:
quoted hunk ↗ jump to hunk
In set_inode_xattr(), there are two returns as follows,
-
  return retval;
  return 0;
-
Here, we remove useless 'return 0;' code.

Signed-off-by: Zhiqiang Liu <redacted>
---
 misc/create_inode.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/misc/create_inode.c b/misc/create_inode.c
index 54d8d343..d62e1cb4 100644
--- a/misc/create_inode.c
+++ b/misc/create_inode.c
@@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino,
 		retval = retval ? retval : close_retval;
 	}
 	return retval;
-	return 0;
 }
 #else /* HAVE_LLISTXATTR */
 static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help