Re: [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write()
From: Eric Biggers <ebiggers@kernel.org>
Date: 2021-02-10 18:05:29
Also in:
linux-block, linux-f2fs-devel, linux-fsdevel
On Sun, Feb 07, 2021 at 11:04:25AM -0800, Chaitanya Kulkarni wrote:
Signed-off-by: Chaitanya Kulkarni <redacted>
No explanation in commit message? There isn't much explanation needed for this, but there should be at least one sentence. Likewise for the other patches.
quoted hunk ↗ jump to hunk
fs/f2fs/verity.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c index 44e057bdc416..ca019685a944 100644 --- a/fs/f2fs/verity.c +++ b/fs/f2fs/verity.c@@ -79,7 +79,6 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, PAGE_SIZE - offset_in_page(pos)); struct page *page; void *fsdata; - void *addr; int res; res = pagecache_write_begin(NULL, inode->i_mapping, pos, n, 0,@@ -87,9 +86,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, if (res) return res; - addr = kmap_atomic(page); - memcpy(addr + offset_in_page(pos), buf, n); - kunmap_atomic(addr); + memcpy_to_page(page, offset_in_page(pos) buf, n);
This is missing a comma between 'offset_in_page(pos)' and 'buf'.
Otherwise the patches to fs/{ext4,f2fs}/verity.c look fine; thanks for doing
this!
- Eric