Re: [PATCH] ext4: stop update inode before return
From: harshad shirwadkar <hidden>
Date: 2021-01-20 17:48:12
Also in:
lkml
Thanks Pan for the fix. Looks good to me. Reviewed-by: Harshad Shirwadkar <redacted> On Tue, Jan 19, 2021 at 3:04 AM Pan Bian [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Stop inode updating before returning the error code. Fixes: aa75f4d3daae ("ext4: main fast-commit commit path") Signed-off-by: Pan Bian <redacted> --- fs/ext4/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index c173c8405856..64039bbb656d 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c@@ -5389,8 +5389,10 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) inode->i_gid = attr->ia_gid; error = ext4_mark_inode_dirty(handle, inode); ext4_journal_stop(handle); - if (unlikely(error)) + if (unlikely(error)) { + ext4_fc_stop_update(inode); return error; + } } if (attr->ia_valid & ATTR_SIZE) { --2.17.1