Thread (3 messages) 3 messages, 3 authors, 2021-01-14

Re: [PATCH] Use IS_ERR instead of IS_ERR_OR_NULL and set inode null when IS_ERR.

From: "Theodore Ts'o" <tytso@mit.edu>
Date: 2021-01-14 03:33:47
Also in: lkml

On Wed, Jan 06, 2021 at 02:02:11PM +0100, Jan Kara wrote:
On Wed 30-12-20 11:38:27, Yi Li wrote:
quoted
1: ext4_iget/ext4_find_extent never returns NULL, use IS_ERR
instead of IS_ERR_OR_NULL to fix this.

2: ext4_fc_replay_inode should set the inode to NULL when IS_ERR.
and go to call iput properly.

Signed-off-by: Yi Li <redacted>
Thanks for the patch! It looks good to me. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>
Thanks, applied.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help