Thread (21 messages) 21 messages, 5 authors, 2021-02-07

Re: [PATCH 4/6] fs-verity: support reading Merkle tree with ioctl

From: Eric Biggers <ebiggers@kernel.org>
Date: 2021-01-28 02:18:04
Also in: linux-api, linux-f2fs-devel, linux-fscrypt, linux-fsdevel

On Wed, Jan 27, 2021 at 05:10:39PM -0800, Jaegeuk Kim wrote:
Minor thought:
How about invalidating or truncating merkel tree pages?

Reviewed-by: Jaegeuk Kim <jaegeuk@kernel.org>
Removing them from the page cache after the read, you mean?  I'm not sure we can
assume that users of this ioctl would want the pages to *not* be cached, any
more than we could assume that for any regular read().  I think we should just
leave the pages cached (like a regular read) and not do anything special.  Like
other pagecache pages, the kernel will evict the Merkle tree pages eventually if
they aren't being accessed anymore and memory needs to be reclaimed.

- Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help