Thread (10 messages) 10 messages, 2 authors, 2020-08-07

Re: [PATCH v3 2/5] ext4: remove ext4_buffer_uptodate()

From: tytso@mit.edu
Date: 2020-08-07 17:53:48
Also in: linux-fsdevel

On Sat, Jun 20, 2020 at 10:54:24AM +0800, zhangyi (F) wrote:
After we add async write error check in ext4_journal_get_write_access(),
we can remove the partial fix for filesystem inconsistency problem
caused by reading old data from disk, which in commit <7963e5ac9012>
"ext4: treat buffers with write errors as containing valid data" and
<cf2834a5ed57> "ext4: treat buffers contining write errors as valid in
ext4_sb_bread()".

Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
I think it's better to keep these checks (in commits 2 and 3) because
ext4_error() doens't guarantee that the file system will be aborted.
For better or for worse, there are a large number of file systems
which default to errors=continue.

So if we notice that the buffer is not up to date, due to a write
error, we can avoid some (although not all) damage if we keep this
workaround.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help