Thread (11 messages) 11 messages, 5 authors, 2020-06-09

Re: [PATCHv5 3/5] ext4: mballoc: Introduce pcpu seqcnt for freeing PA to improve ENOSPC handling

From: Borislav Petkov <bp@alien8.de>
Date: 2020-06-09 10:20:30
Also in: linux-fsdevel, lkml

On Wed, Jun 03, 2020 at 03:40:16PM +0530, Ritesh Harjani wrote:
Yes, this is being discussed in the community.
I have submitted a patch which should help fix this warning msg.
Feel free to give this a try on your setup.

https://marc.info/?l=linux-ext4&m=159110574414645&w=2
I just triggered the same thing here too. Looking at your fix and not
even pretending to know what's going on with that percpu sequence
counting, I can't help but wonder why do you wanna do:

	seq = *raw_cpu_ptr(&discard_pa_seq);

instead of simply doing:

	seq = this_cpu_read(discard_pa_seq);

?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help