Thread (15 messages) 15 messages, 7 authors, 2020-05-12

Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize

From: Ritesh Harjani <ritesh.list@gmail.com>
Date: 2020-05-11 08:08:08
Also in: stable

Hello stable-list,

I think this subjected patch [1] missed the below fixes tag.
I guess the subjected patch is only picked for 5.7. And
AFAIU, this patch will be needed for 5.6 as well.

Could you please do the needful.

Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default)

[1]: 
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1


-ritesh

On 3/29/20 7:47 AM, Theodore Y. Ts'o wrote:
On Sat, Mar 28, 2020 at 01:37:44AM +0530, Ritesh Harjani wrote:
quoted
Currently on calling echo 3 > drop_caches on host machine, we see
FS corruption in the guest. This happens on Power machine where
blocksize < pagesize.

So as a temporary workaound don't enable dioread_nolock by default
for blocksize < pagesize until we identify the root cause.

Also emit a warning msg in case if this mount option is manually
enabled for blocksize < pagesize.

Reported-by: Aneesh Kumar K.V <redacted>
Signed-off-by: Ritesh Harjani <redacted>
Thanks, applied.

					- Ted
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help