Re: [PATCH v8 14/25] mm: Document why we don't set PageReadahead

[PATCH v8 00/25] Change readahead API · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 01/25] mm: Move readahead prototypes from mm.h · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 09/25] mm: Remove 'page_offset' from readahead loop · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 16/25] fs: Convert mpage_readpages to mpage_readahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 24/25] fuse: Convert from readpages to readahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 03/25] mm: Ignore return value of ->readpages · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 06/25] mm: Use readahead_control to pass arguments · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 04/25] mm: Move readahead nr_pages check into read_pages · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 14/25] mm: Document why we don't set PageReadahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
Re: [PATCH v8 14/25] mm: Document why we don't set PageReadahead · Christoph Hellwig <hch@infradead.org> · 2020-02-26
[PATCH v8 05/25] mm: Add new readahead_control API · Matthew Wilcox <willy@infradead.org> · 2020-02-25
Re: [PATCH v8 05/25] mm: Add new readahead_control API · Christoph Hellwig <hch@infradead.org> · 2020-02-26
[PATCH v8 07/25] mm: Rename various 'offset' parameters to 'index' · Matthew Wilcox <willy@infradead.org> · 2020-02-25
Re: [PATCH v8 07/25] mm: Rename various 'offset' parameters to 'index' · Zi Yan <ziy@nvidia.com> · 2020-02-26
[PATCH v8 19/25] erofs: Convert compressed files from readpages to readahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 13/25] mm: Add page_cache_readahead_unbounded · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 18/25] erofs: Convert uncompressed files from readpages to readahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 23/25] f2fs: Pass the inode to f2fs_mpage_readpages · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 22/25] f2fs: Convert from readpages to readahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 20/25] ext4: Convert from readpages to readahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 21/25] ext4: Pass the inode to ext4_mpage_readpages · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 25/25] iomap: Convert from readpages to readahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
Re: [PATCH v8 25/25] iomap: Convert from readpages to readahead · Darrick J. Wong <hidden> · 2020-02-26
Re: [PATCH v8 25/25] iomap: Convert from readpages to readahead · Christoph Hellwig <hch@infradead.org> · 2020-02-26
Re: [PATCH v8 25/25] iomap: Convert from readpages to readahead · Darrick J. Wong <hidden> · 2020-02-26
Re: [PATCH v8 25/25] iomap: Convert from readpages to readahead · Christoph Hellwig <hch@infradead.org> · 2020-02-26
[PATCH v8 17/25] btrfs: Convert from readpages to readahead · Matthew Wilcox <willy@infradead.org> · 2020-02-25
Re: [PATCH v8 17/25] btrfs: Convert from readpages to readahead · Christoph Hellwig <hch@infradead.org> · 2020-02-26
Re: [PATCH v8 17/25] btrfs: Convert from readpages to readahead · David Sterba <hidden> · 2020-02-28
[PATCH v8 10/25] mm: Put readahead pages in cache earlier · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 15/25] mm: Use memalloc_nofs_save in readahead path · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 11/25] mm: Add readahead address space operation · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 08/25] mm: rename readahead loop variable to 'i' · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 02/25] mm: Return void from various readahead functions · Matthew Wilcox <willy@infradead.org> · 2020-02-25
[PATCH v8 12/25] mm: Move end_index check out of readahead loop · Matthew Wilcox <willy@infradead.org> · 2020-02-25
Re: [PATCH v8 00/25] Change readahead API · Christoph Hellwig <hch@infradead.org> · 2020-03-19
Re: [PATCH v8 00/25] Change readahead API · Matthew Wilcox <willy@infradead.org> · 2020-03-19
Re: [PATCH v8 00/25] Change readahead API · William Kucharski <hidden> · 2020-03-19

From: Christoph Hellwig <hch@infradead.org>
Date: 2020-02-26 17:04:04
Also in: linux-btrfs, linux-f2fs-devel, linux-fsdevel, linux-mm, linux-xfs, lkml, ocfs2-devel

On Tue, Feb 25, 2020 at 01:48:27PM -0800, Matthew Wilcox wrote:

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

If the page is already in cache, we don't set PageReadahead on it.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help