Thread (26 messages) 26 messages, 4 authors, 2019-05-14

Re: [PATCH v8 2/6] virtio-pmem: Add virtio pmem driver

From: Pankaj Gupta <hidden>
Date: 2019-05-14 10:02:58
Also in: kvm, linux-acpi, linux-fsdevel, linux-xfs, lkml, nvdimm, qemu-devel

quoted
quoted
I think you should do the same here, vdev->priv is allocated in
virtio_pmem_probe.

But maybe I am missing something important here :)
Because virtio_balloon use "kzalloc" for allocation and needs to be freed.
But virtio pmem uses "devm_kzalloc" which takes care of automatically
deleting
the device memory when associated device is detached.
Hehe, thanks, that was the part that I was missing!
Thank you for the review.

Best regards,
Pankaj
--

Thanks,

David / dhildenb
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help